Change current datetime to UTC timezone #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| new_versions = {} | ||
| current_datetime = datetime.now() | ||
| current_datetime = datetime.now(timezone.utc).replace(tzinfo=None) |
Member
There was a problem hiding this comment.
Why do you strip the timezone from the result?
Collaborator
Author
There was a problem hiding this comment.
It is to convert a timezone-aware datetime into a naive datetime (i.e., a datetime without any timezone for elasticsearch.
e.g.
2025-11-03 08:30:00+00:00
to
2025-11-03 08:30:00
Collaborator
Author
|
@RobertKrawitz, any more comments ? |
RobertKrawitz
approved these changes
Nov 11, 2025
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebattat, RobertKrawitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ebattat
added a commit
to ebattat/benchmark-runner
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Using local time caused missing Elasticsearch rows when fetching. Switching to UTC ensures all IDs are fetched correctly.
For security reasons, all pull requests need to be approved first before running any automated CI